Propagate desktop JVM dependencies only when invoked by Compose previews#94
Merged
Merged
Conversation
02ce9a0 to
b972988
Compare
b972988 to
ec8e922
Compare
SalvatoreT
approved these changes
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GradleUtils.getComposePreviewVariant(), which returns aVariantwhen the build was invoked by Compose previews.Variant.Debugduring IDE sync, which effectively prevents support for release mode Compose previews. An issue for this is opened at Release mode Compose previews are not supported #99.Variant.Releasewhen invoked from release mode Compose previews, but since during IDE sync the JAR file for the debug build is used, the release preview tries to find the debug mode Rust dynamic library.nullduring normal builds.runtimeOnlyonly ifGradleUtils.getComposePreviewVariant()returnsVariant.Debug. This makes them removed during normal builds.DependencyUtils.resolveUniFfiDependenciesalways register JNA as a dependency, as it is used inside Compose previews or unit tests so it is not included in the final app. This is to prevent resolving dependencies during configuration.Testing
Tested with the Android tutorial added by #62. Compose test code is as follows.
Tested with a multi-module project as well.
Issues Fixed
Fixes: #92