fix issue #2782 that orm builder generate incorrect sql in some case#2787
Merged
Conversation
Member
|
@Agzer0 Thanks for your contribution, but please commit associated unit testing case for this update. Please add the unit testing case here: https://github.com/gogf/gf/blob/master/contrib/drivers/mysql/mysql_issue_test.go . There're reference cases already for you. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2787 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 632 632
Lines 52174 52174
=======================================
+ Hits 41298 41300 +2
+ Misses 8830 8828 -2
Partials 2046 2046
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
okay, i`ve added testing case |
gqcn
approved these changes
Jul 25, 2023
lingcoder
added a commit
to lingcoder/gf
that referenced
this pull request
Apr 14, 2026
Add 38 issue regression tests ported from MariaDB baseline, bringing the total from 9 to 47. Tests cover JSON scanning (gogf#1380), ScanList (gogf#1570), With/WithAll (gogf#1401, gogf#1412, gogf#2119), timestamp comparison (gogf#1002), case-sensitive columns (gogf#1700), OmitEmpty (gogf#2561, gogf#3204), FieldsEx soft-time (gogf#3754), Hook+concurrent (gogf#3238), cache Hook (gogf#3626), Order variations (gogf#3932), ScanAndCount+Hook (gogf#3968), column comparison with Raw (gogf#3915), AllAndCount/Distinct (gogf#4698), Fields empty string (gogf#4697), ClearTableFields (gogf#2552), sub-query model (gogf#2339), Delete guard (gogf#2427), batch duplicate key (gogf#3086), JSON null/array scan (gogf#4086), sys_config JSON (gogf#3218), Transaction+Save (gogf#4034), Builder conditions (gogf#2787), WherePrefixNotIn (gogf#2907), InnerJoinOnField (gogf#2439), and captured SQL quoting (gogf#3649). MySQL-specific tests (IF(), zerofill, BIGINT UNSIGNED, cross-schema, lpad/concat_ws, MariaDB regex) are present as skip stubs to maintain function-name parity. 12 PgSQL-dialect testdata SQL files added for tests that depend on external schema definitions. ref gogf#4689
lingcoder
added a commit
to lingcoder/gf
that referenced
this pull request
Apr 23, 2026
Add 38 issue regression tests ported from MariaDB baseline, bringing the total from 9 to 47. Tests cover JSON scanning (gogf#1380), ScanList (gogf#1570), With/WithAll (gogf#1401, gogf#1412, gogf#2119), timestamp comparison (gogf#1002), case-sensitive columns (gogf#1700), OmitEmpty (gogf#2561, gogf#3204), FieldsEx soft-time (gogf#3754), Hook+concurrent (gogf#3238), cache Hook (gogf#3626), Order variations (gogf#3932), ScanAndCount+Hook (gogf#3968), column comparison with Raw (gogf#3915), AllAndCount/Distinct (gogf#4698), Fields empty string (gogf#4697), ClearTableFields (gogf#2552), sub-query model (gogf#2339), Delete guard (gogf#2427), batch duplicate key (gogf#3086), JSON null/array scan (gogf#4086), sys_config JSON (gogf#3218), Transaction+Save (gogf#4034), Builder conditions (gogf#2787), WherePrefixNotIn (gogf#2907), InnerJoinOnField (gogf#2439), and captured SQL quoting (gogf#3649). MySQL-specific tests (IF(), zerofill, BIGINT UNSIGNED, cross-schema, lpad/concat_ws, MariaDB regex) are present as skip stubs to maintain function-name parity. 12 PgSQL-dialect testdata SQL files added for tests that depend on external schema definitions. ref gogf#4689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issues #2782 : When ORM is constructing multiple SQL conditions, the OmitEmpty option is used. If the first condition is empty conditions and the second condition is the compound condition. At this time, when there is still a third condition, the generated SQL is wrong.