Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

middleware/recover/recover_test.go (1)

16-24: ⚠️ Potential issue | 🔴 Critical

require inside ErrorHandler violates the linter rule, and the assertion compares the wrong error.

Two unresolved problems in Test_Recover:

1. Linter violation – require.Equal inside the ErrorHandler closure panics the test goroutine on failure instead of failing the test; use t.Errorf inside handlers.
2. Wrong assertion – The custom ErrorCustomizer returns fiber.ErrInternalServerError, so ErrorHandler receives that error ("Internal Server Error"), not the panic string. The assertion against "[RECOVERED]: Hi, I'm an error!" will always fail.

🐛 Proposed fix

	ErrorHandler: func(c fiber.Ctx, err error) error {
-		require.Equal(t, "[RECOVERED]: Hi, I'm an error!", err.Error())
+		if err == nil || err.Error() != fiber.ErrInternalServerError.Error() {
+			t.Errorf("expected %q, got %v", fiber.ErrInternalServerError.Error(), err)
+		}
		return c.SendStatus(fiber.StatusTeapot)
	},

Based on learnings: in the Fiber codebase, the linter does not allow require assertions from within HTTP handlers; use t.Fatalf, t.Errorf, or similar testing.T methods instead.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@middleware/recover/recover_test.go` around lines 16 - 24, Test_Recover's
ErrorHandler closure uses require.Equal (which panics) and asserts the wrong
string; replace the require call inside the ErrorHandler with a testing.T method
(e.g., t.Errorf or t.Fatalf) to avoid panicking the test goroutine, and change
the asserted error text to match the ErrorCustomizer return value
(fiber.ErrInternalServerError.Error()) so ErrorHandler checks for "Internal
Server Error" instead of "[RECOVERED]: Hi, I'm an error!"; locate the closure
passed as ErrorHandler in Test_Recover and update the assertion and assertion
helper accordingly.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

middleware/recover/recover_test.go (1)

18-19: ⚠️ Potential issue | 🟠 Major

Avoid require inside ErrorHandler closures.

Same issue as previously flagged: the linter disallows require.* in HTTP handlers. Use t.Errorf (or similar) inside the handler instead.

Based on learnings: In the Fiber codebase, the linter does not allow require assertions from within HTTP handlers (including net/http-style handlers).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@middleware/recover/recover_test.go` around lines 18 - 19, The test's
ErrorHandler closure uses require.Equal inside the HTTP handler
(require.Equal(..., err.Error())), which the linter forbids; replace that
require call with t.Errorf (or t.Fatalf) to report the mismatch from the handler
instead of calling require, e.g., compare err.Error() to the expected string and
call t.Errorf with a descriptive message if it differs, leaving the rest of the
handler (return c.SendStatus(fiber.StatusTeapot)) unchanged so the test still
exercises the response path.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

middleware/recover/recover_test.go (1)

17-21: ⚠️ Potential issue | 🔴 Critical

require.Equal inside the ErrorHandler violates the linter rule.

The require assertion on line 18 is inside a fiber.Ctx-typed handler closure. The linter forbids require calls within HTTP handlers; use t.Errorf instead.

✅ Proposed fix

 	ErrorHandler: func(c fiber.Ctx, err error) error {
-		require.Equal(t, "[RECOVERED]: Hi, I'm an error!", err.Error())
+		if err == nil || err.Error() != "[RECOVERED]: Hi, I'm an error!" {
+			t.Errorf("expected %q, got %v", "[RECOVERED]: Hi, I'm an error!", err)
+		}
 		return c.SendStatus(fiber.StatusTeapot)
 	},

Based on learnings: "the linter does not allow require assertions from within HTTP handlers (including net/http-style handlers). Use t.Fatalf, t.Errorf, or similar testing.T methods for error handling inside handler functions instead."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@middleware/recover/recover_test.go` around lines 17 - 21, The test handler's
ErrorHandler closure uses require.Equal (inside the anonymous func(c fiber.Ctx,
err error) error) which violates the linter for HTTP handlers; replace the
require call with a testing.T method (e.g., t.Errorf or t.Fatalf) to report the
mismatch—check that err.Error() equals "[RECOVERED]: Hi, I'm an error!" using
t.Errorf/fatal and then return c.SendStatus(fiber.StatusTeapot) as before so the
assertion runs without using require inside ErrorHandler.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro