Skip to content

🐛 bug: preserve idempotency replay protection for oversized responses #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaby wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −10
Open

🐛 bug: preserve idempotency replay protection for oversized responses #4287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions middleware/idempotency/idempotency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@ func New(config ...Config) fiber.Handler {
}
}

bodyLimit := c.App().Config().BodyLimit
if bodyLimit > 0 && len(res.Body) > bodyLimit {
_ = c.Locals(localsKeyWasPutToCache, false)
return nil
}

// Marshal response
bs, err := res.MarshalMsg(nil)
if err != nil {
Expand Down
8 changes: 4 additions & 4 deletions middleware/idempotency/idempotency_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ func Test_New_StoreRetrieve_FilterHeaders(t *testing.T) {
require.Equal(t, 1, s.setCount)
}

func Test_New_SkipCache_WhenBodyTooLarge(t *testing.T) {
func Test_New_Cache_WhenBodyTooLarge(t *testing.T) {
t.Parallel()
bodyLimit := 8
app := fiber.New(fiber.Config{BodyLimit: bodyLimit})
Expand Down Expand Up @@ -374,10 +374,10 @@ func Test_New_SkipCache_WhenBodyTooLarge(t *testing.T) {
require.Equal(t, fiber.StatusOK, resp2.StatusCode)
require.Equal(t, oversized, body2)

require.Equal(t, 2, count)
require.Equal(t, 0, s.setCount)
require.Equal(t, 1, count)
require.Equal(t, 1, s.setCount)
require.Len(t, wasPut, 2)
require.False(t, wasPut[0])
require.True(t, wasPut[0])
require.False(t, wasPut[1])
}

Expand Down
Loading