client/cookiejar_test.go (1)

638-671: 💤 Low value

Variable names with is* prefix should be reserved for booleans.

The variables isHostOnlyOrigin and isHostOnlyCookie are a *fasthttp.URI and *fasthttp.Cookie respectively, not booleans. The is* prefix conventionally signals a boolean type, making these names misleading.

The original names hostOnlyOrigin and hostOnlyCookie were appropriate compound nouns describing "the origin for a host-only cookie" and "a host-only cookie". The PR's scope is renaming boolean fields, not all occurrences of hostOnly in variable names.

Suggested revert to original variable names

-			isHostOnlyOrigin := fasthttp.AcquireURI()
-			defer fasthttp.ReleaseURI(isHostOnlyOrigin)
-			require.NoError(t, isHostOnlyOrigin.Parse(nil, []byte("http://example.com/")))
+			hostOnlyOrigin := fasthttp.AcquireURI()
+			defer fasthttp.ReleaseURI(hostOnlyOrigin)
+			require.NoError(t, hostOnlyOrigin.Parse(nil, []byte("http://example.com/")))
 
 			domainOrigin := fasthttp.AcquireURI()
 			defer fasthttp.ReleaseURI(domainOrigin)
 			require.NoError(t, domainOrigin.Parse(nil, []byte("http://sub.example.com/")))
 
-			isHostOnlyCookie := &fasthttp.Cookie{}
-			isHostOnlyCookie.SetKey("host-only")
-			isHostOnlyCookie.SetValue("123")
+			hostOnlyCookie := &fasthttp.Cookie{}
+			hostOnlyCookie.SetKey("host-only")
+			hostOnlyCookie.SetValue("123")
 
 			domainCookie := &fasthttp.Cookie{}
 			domainCookie.SetKey("domain")
 			domainCookie.SetValue("456")
 			domainCookie.SetDomain("example.com")
 
 			for _, cookieType := range testCase.order {
 				switch cookieType {
 				case "host-only":
-					jar.Set(isHostOnlyOrigin, isHostOnlyCookie)
+					jar.Set(hostOnlyOrigin, hostOnlyCookie)
 				case "domain":
 					jar.Set(domainOrigin, domainCookie)
 				default:
 					t.Fatalf("unexpected cookie type %q", cookieType)
 				}
 			}
 
 			anotherSubdomain := fasthttp.AcquireURI()
 			defer fasthttp.ReleaseURI(anotherSubdomain)
 			require.NoError(t, anotherSubdomain.Parse(nil, []byte("http://child.example.com/")))
 			require.Equal(t, []string{"domain"}, cookieKeys(jar.Get(anotherSubdomain)))
 
-			require.ElementsMatch(t, []string{"domain", "host-only"}, cookieKeys(jar.Get(isHostOnlyOrigin)))
+			require.ElementsMatch(t, []string{"domain", "host-only"}, cookieKeys(jar.Get(hostOnlyOrigin)))

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@client/cookiejar_test.go` around lines 638 - 671, The variable names
isHostOnlyOrigin and isHostOnlyCookie use an "is*" prefix which implies a
boolean but they are a *fasthttp.URI and *fasthttp.Cookie; rename them back to
hostOnlyOrigin and hostOnlyCookie to reflect noun semantics and match the
original intent; update all references in this test block (including the Set/Get
calls on jar and the deferred ReleaseURI calls) so the names are consistent and
avoid boolean-prefix confusion.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes