Fix GetLocationFromRoute bug for optional params#1922
Merged
Conversation
# Conflicts: # app.go # ctx.go
Co-authored-by: hi019 <65871571+hi019@users.noreply.github.com>
Member
|
@sujit-baniya please check the tests |
The optional and greedy params were not fetched correctly
The optional and greedy params were not fetched correctly
The optional and greedy params were not fetched correctly
ReneWerner87
approved these changes
May 31, 2022
trim21
pushed a commit
to trim21/fiber
that referenced
this pull request
Aug 15, 2022
* Add Global Layout for view render * Add test case for Views Layout * Update ctx_test.go * Add App Name function to pass custom app name * Remove json tag for function * Change func to string * Add test for AppName * Add RedirectToRoute and RedirectBack with fallback if referer in header not found * replace errors.New with fmt.Errorf * simplified code * Add tests for different formats * Add method to get route location and add benchmarks * Add ToString function * Fix error * rearrange case for fmt.Stringer * Fix bug for error return * Lock latest route for app.Name(namee string) * decreasing timeout for client test with timeout * remove println and adjust condition to > 0 * Change name to get route url * Change name to get route url * Update ctx.go Co-authored-by: hi019 <65871571+hi019@users.noreply.github.com> * Fix bug on getting url for optional and greedy params * Fix greedy pattern * This PR will fix gofiber#1921 (comment). The optional and greedy params were not fetched correctly * This PR will fix gofiber#1921 (comment). The optional and greedy params were not fetched correctly * This PR will fix gofiber#1921 (comment). The optional and greedy params were not fetched correctly Co-authored-by: RW <rene@gofiber.io> Co-authored-by: hi019 <65871571+hi019@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #1921 (comment).
The optional and greedy params were not fetched correctly