Skip to content

✨ v3 (feature): new Route method#2065

Merged
ReneWerner87 merged 9 commits into
gofiber:v3-betafrom
wangjq4214:feat-new-route
Sep 18, 2022
Merged

✨ v3 (feature): new Route method#2065
ReneWerner87 merged 9 commits into
gofiber:v3-betafrom
wangjq4214:feat-new-route

Conversation

@wangjq4214

Copy link
Copy Markdown
Member

related to #1829

@efectn efectn added this to the v3 milestone Aug 30, 2022
@efectn efectn changed the title Feat new route ✨ v3 (feature): new Route method Aug 30, 2022
@balcieren

balcieren commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

@wangjq4214 Why you changed Route with RouteInfo ?

@wangjq4214

Copy link
Copy Markdown
Member Author

@wangjq4214 Why you changed Route with RouteInfo ?

I think the method returned by this function is probably more commonly used, so a simpler name is needed. Changing the previous name is not quite right, I will change it back, do you have any idea about the name of this type?

@wangjq4214 wangjq4214 marked this pull request as ready for review August 31, 2022 14:10
Comment thread register.go Outdated
Comment thread register.go
@balcieren

Copy link
Copy Markdown
Contributor

@wangjq4214 We can use Router interface for this method

@efectn

efectn commented Aug 31, 2022

Copy link
Copy Markdown
Member

Router interface is not compatible for this stuff. It has path param in methods

@balcieren

Copy link
Copy Markdown
Contributor

Router interface is not compatible for this stuff. It has path param in methods

That's true. You are right.

@balcieren

Copy link
Copy Markdown
Contributor

I think we should change Route struct name

@efectn

efectn commented Sep 1, 2022

Copy link
Copy Markdown
Member

Maybe we can add interface named RegisterI or something else and return it instead of *Register. Wdym @wangjq4214

@balcieren

balcieren commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

Actually RouteFunc might be a good name to seperate from Route

@ReneWerner87

Copy link
Copy Markdown
Member

@wangjq4214 thx for the PR

can you create some test with route which have a deeper level

so for example 3 level

so we can be sure that there can be scaled infinitely

@wangjq4214

Copy link
Copy Markdown
Member Author

@efectn thx

@ReneWerner87 ReneWerner87 merged commit 093882c into gofiber:v3-beta Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants