Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

fix: make empty AuthScheme possible for headers#123

Merged
ReneWerner87 merged 3 commits into
gofiber:masterfrom
418Coffee:master
Apr 21, 2023
Merged

fix: make empty AuthScheme possible for headers#123
ReneWerner87 merged 3 commits into
gofiber:masterfrom
418Coffee:master

Conversation

@418Coffee
Copy link
Copy Markdown
Contributor

This PR fixes #118.
It uses an identical solution as the keyauth middleware package.

@418Coffee 418Coffee changed the title fix #48: make empty AuthScheme possible for headers fix: make empty AuthScheme possible for headers Apr 12, 2023
@ReneWerner87
Copy link
Copy Markdown
Member

@418Coffee thx for the change
can you add something in the documentation for this and maybe a unittest?

@418Coffee
Copy link
Copy Markdown
Contributor Author

Hi @ReneWerner87 ,

I made the documentation reflect the change in default behaviour and added a unit test.
Please let me know if you need anything else.

@ReneWerner87
Copy link
Copy Markdown
Member

Will check it on friday

@ReneWerner87 ReneWerner87 self-assigned this Apr 19, 2023
@ReneWerner87 ReneWerner87 merged commit 0c03b8d into gofiber:master Apr 21, 2023
@ReneWerner87 ReneWerner87 added ☢️ Bug Something isn't working and removed 🧹 Updates labels Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty AuthScheme not possible for headers

2 participants