Support icon color#1674
Conversation
joelim-work
left a comment
There was a problem hiding this comment.
Thanks for the patch, overall looks good. The only downside to this approach is that you can't specify icon colors using environment variables, but it's probably not worth doing anyway.
In addition, I suggest you should:
- Change the unit tests for
readPairsto testreadArraysinstead. - Update the documentation for icons.
- Add some examples (commented out) to the
etc/icons.exampleconfig file.
| } | ||
|
|
||
| pairs = append(pairs, pair) | ||
| pairs = append(pairs, arr) |
There was a problem hiding this comment.
I think you might want to rename this variable:
| pairs = append(pairs, arr) | |
| arrs = append(arrs, arr) |
|
@joelim-work Updated, check again pls. 🙏 |
joelim-work
left a comment
There was a problem hiding this comment.
Looks good, thanks once again for the changes.
| # other formats | ||
| *.pdf | ||
|
|
||
| # icons with color |
There was a problem hiding this comment.
OPTIONAL: This is just an idea, maybe it might be worth moving this into a separate file (e.g. icons_colored.example). But either way is OK for me.
There was a problem hiding this comment.
I think that is a good idea too. Already moved.
|
Thank you very much @wodesuck for the patch and @joelim-work for the review. There is some conflict in this patch after #1644 is merged, and I wasn't sure how to resolve them. Can you please update the patch one more time? Sorry for the inconvenience as we have been holding many feature patches for a while due to the new release. |
|
@gokcehan Conflict resolved. |
Implement #928 #1520. Now you can add the third column in
~/.config/lf/iconsto set icon colors, fallback to filename color in~/.config/lf/colorsif icon color is not specified.Example:
Also implement #992. You can remove icons by writting only one column in
~/.config/lf/icons, for example: