feat: add mode, user and group info parameters#1799
Merged
Conversation
joelim-work
reviewed
Sep 13, 2024
joelim-work
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for submitting this. I have some minor comments, but overall I think the changes are good and can be merged soon.
|
|
||
| A list of information that is shown for directory items at the right side of the pane. | ||
| Currently supported information types are `size`, `time`, `atime`, and `ctime`. | ||
| Currently supported information types are `size`, `time`, `atime`, `ctime`, `mode`, `user` and `group`. |
Collaborator
There was a problem hiding this comment.
Just wondering, do you think instead of using mode, something like perm or permissions is more intuitive as the name here? Might be a good idea to check what other file managers are using.
Contributor
Author
There was a problem hiding this comment.
Yeah I agree, I will change it to perm.
| } | ||
| } | ||
|
|
||
| func getGroupWidth(dir *dir, beg int, end int) int { |
Collaborator
There was a problem hiding this comment.
You mixed up the function names:
Suggested change
| func getGroupWidth(dir *dir, beg int, end int) int { | |
| func getUserWidth(dir *dir, beg int, end int) int { |
| return maxw | ||
| } | ||
|
|
||
| func getUserWidth(dir *dir, beg int, end int) int { |
Collaborator
There was a problem hiding this comment.
Same here:
Suggested change
| func getUserWidth(dir *dir, beg int, end int) int { | |
| func getGroupWidth(dir *dir, beg int, end int) int { |
joelim-work
approved these changes
Sep 13, 2024
joelim-work
left a comment
Collaborator
There was a problem hiding this comment.
Thanks once again for the changes 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1554