Misc improvements for nav.checkDir#2050
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
app.nav.dirChan.indandposvalues are no longer set to 0 because that is the default value anyway.nav.checkDirnow exits early if the directory is already loading - the purpose of the function is to check if the directory needs reloading, and trigger one if so.loadTimeis now only set when the directory has actually been loaded. OriginallyloadTimewas also set immediately before triggering a reload, to prevent additional attempts to reload the directory when it is already in progress, but this should be taken care of by the loading check above.This is also fixes a bug when
dircacheis disabled:lfwithset dircache false$touch file)