Fix overscroll related to drawbox#2210
Conversation
|
Hey @joelim-work! I am unsure about your intend behind removing the I also noticed inside #2206 that you changed the behaviour of |
|
Thanks for finding this bug - about your questions:
It was just me forgetting that the nav height is affected by the
This is specific for preloading and for volatile previews, but if the preview cache is completely cleared each time there is a resize, then the preview will have to be preloaded (one script call) and then previewed (another script call). The preloading step is unnecessary for volatile previews since there is nothing in the cache to update (there is just a dummy entry marked as volatile), and the new dimensions is passed in the previewing step which is then used by Now as for this PR, the above patch is probably fine as a quick bug fix, but a more complete fix would be to create a function in the
|
All right. I will merge this one then and wait with a proper fix till #2206 is merged. |
|
That's OK, I did this in #2218 |
set drawboxwhen started withset nodrawbox#2209