Skip to content

fix: improve width calculation for ratios option#2347

Merged
joelim-work merged 4 commits into
gokcehan:masterfrom
joelim-work:getwidths
Jan 14, 2026
Merged

fix: improve width calculation for ratios option#2347
joelim-work merged 4 commits into
gokcehan:masterfrom
joelim-work:getwidths

Conversation

@joelim-work

Copy link
Copy Markdown
Collaborator

This PR makes a couple of small improvements to the calculation of window widths when the ratios option is applied:

  • Previously space would not be set aside for dividers when calculating window widths, and instead each window would just leave its final column blank to simulate a divider when drawing the UI. Now the space for dividers is allocated properly and does not form part of the window dimensions.
  • Window widths are floored if they are not whole numbers, and the discarded fractional parts are accumulated and added only to the rightmost window, which can cause it to be larger than expected. Now the discarded fractional parts will be added to each successive window where possible, so that it is spread out and not added to just one window at the end.

@joelim-work joelim-work merged commit b5d981a into gokcehan:master Jan 14, 2026
32 checks passed
@joelim-work joelim-work deleted the getwidths branch January 14, 2026 00:13
@joelim-work joelim-work added the fix Pull requests that fix existing behavior label Jan 22, 2026
@joelim-work joelim-work added this to the r41 milestone Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Pull requests that fix existing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant