Don't redraw volatile previews on ticker period#546
Merged
Conversation
Owner
|
@neeshy Thanks for the solution. Would it not be possible to simply add a conditional to the ticker since it is only different in a single place? Something like: This seems to work with the non-caching version of my preview highlight script. I don't have an image setup yet so I'm not sure if it works. |
Contributor
Author
|
@gokcehan The problem with that patch is that the preview won't be regenerated when the modification time changes. So, disabling calling the |
Owner
|
@neeshy Ah, I see, don't mind me, I will just merge this patch then, thanks. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542
There's probably a more elegant solution to this though.