Add unit test for DeleteManifest method in TencentCR adapter #22537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anurag Ojha <aojharaj2004@gmail.com>
33ee4a3 to
0754346
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22537 +/- ##
===========================================
+ Coverage 45.36% 65.85% +20.48%
===========================================
Files 244 1073 +829
Lines 13333 116079 +102746
Branches 2719 2931 +212
===========================================
+ Hits 6049 76445 +70396
- Misses 6983 35399 +28416
- Partials 301 4235 +3934
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hey @chlins @MinerYang, I added a test . Can you take a look if you have a moment that my approach is good to go ?? |
|
Hey @Vad1mo , @wy65701436 , Can you take a look on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test for the
DeleteManifestfunction in the Tencent Container Registry (TCR) adapter.Changes:
mockAdapterto simulate the delete behavior without calling real Tencent Cloud APIs.<namespace>/<repo>pattern.