chore(logging): log the problematic event for #12122 #14092
Conversation
Summary of ChangesHello @briandealwis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the diagnostic capabilities of the system by modifying an error logging statement. When an unknown error occurs during an LLM stream, the full event object will now be included in the log message. This change aims to provide more comprehensive information for debugging scenarios where specific error messages might be missing, thereby improving the ability to understand and resolve such issues. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to improve error logging for unknown LLM stream errors by including the problematic event in the error message. This is a good initiative for better debugging. However, the current implementation using template literal interpolation on the event object will result in it being logged as "[object Object]", which doesn't provide the needed detail. My review includes a specific suggestion to use JSON.stringify() to properly serialize the event object, ensuring its contents are fully captured in the logs.
58a3f2c to
11a70f0
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Log the entire event in this unknown-error case.
Details
It appears from the #12122 that the error event being received doesn't have a
value.message, so log the entire event. From internal reports, we sometimes have a trace ID but those appear to be from the initial conversation trace and are successful.How to Validate
By inspection. Unfortunately this doesn't seem to be reproducible.
Pre-Merge Checklist