This repository was archived by the owner on Aug 25, 2025. It is now read-only.
internal/wire: use full go run command in go:generate comment#268
Merged
zombiezen merged 1 commit intoJan 26, 2021
Merged
Conversation
Change the go:generate command to use the full go run ... command to ensure the version specified in the current go module is used instead of the global binary. fix google#160
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
Contributor
|
Sorry for the delay. This is still on my radar to review, but I've been swamped with other life commitments. I will try to get to this sometime over the next few weeks. |
Contributor
Author
|
Sure, no worries |
zombiezen
approved these changes
Jan 26, 2021
Contributor
zombiezen
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your patience!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the go:generate command to use the full go run ... command
to ensure the version specified in the current go module is used
instead of the global binary.
fix #160