Define an object for collecting DSLX interpreter events.#3057
Define an object for collecting DSLX interpreter events.#3057meheff wants to merge 2 commits intogoogle:mainfrom
Conversation
| }; | ||
|
|
||
| // Create a results proto if requested and plumb it through options. | ||
| xls::EvaluatorResultsProto results_proto; |
cf36eee to
bd7bdf3
Compare
|
Any progress on this? Thanks. |
|
@richmckeever: ping for review ? |
|
@meheff Please rebase this when you can; we can't pull it in for final review until conflicts are resolved. |
bd7bdf3 to
f4868dd
Compare
|
Rebased to head... and changed my notifications for the XLS repo to my personal email account as I kept missing responses on my PRs (my work email might as well be /dev/null). |
ericastor
left a comment
There was a problem hiding this comment.
Approving to try to kick off the import.
|
@meheff sorry, I missed this. Can you please add Apache license headers? The migration is failing with: error: Error validating 'verify_match 'Licensed under the Apache Error validating 'verify_match 'Licensed under the Apache License, Version |
f4868dd to
c22d749
Compare
|
Added licenses. |
|
@meheff did you get a change to look at @mikex-oss comments? |
proppy
left a comment
There was a problem hiding this comment.
Can we relax the check in dump_call_trace_test to exclude the line numbers from the match?
|
this also need to be rebased. |
c22d749 to
592d4d3
Compare
592d4d3 to
fba385e
Compare
The newly defined DslxInterpreterEvents gathers assert and trace messages from the DSLX interpreter replacing the previous trace hook mechanism. It stores information in the same proto as the IR interpreter does which enables easier comparison of behavior between the interpreters and the sharing of tools. Also augment the proto with additional information like source information.
Also add a utility dump_call_trace which reads an events proto and prints a structured trace of the calls.