Skip to content

MediaSession play/pause events not propagated to LeanbackPlayerAdapter #10420

Closed

Description

@TheBeastLT

ExoPlayer Version

2.18.0

Devices that reproduce the issue

Any Android TV

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

Connect player with a MediaSession and try to play/pause the video using mobile.

Expected result

When clicking play/pause the controls overlay should be triggered and their state updated.

It seems that the LeanbackPlayerAdapter listens to onPlaybackStateChanged player events, but play/pause action called from MediaSessionConnector. directly on a Player instance triggers only onPlayWhenReadyChanged event, which is not handled in the LeanbackPlayerAdapter.
By using ForwadingPlayer when setting player for the MediaSessionConnector. you can workaround this issue:

mediaSessionConnector.setPlayer(object : ForwardingPlayer(player) {
    override fun play() {
        playerAdapter.play()
    }

    override fun pause() {
        playerAdapter.pause()
    }

    override fun stop() {
        playerAdapter.pause()
    }
})

Actual result

Controls overlay is not triggered and play/pause action stays in previous incorrect state.

Media

Not applicable

Bug Report

Activity

  1. self-assigned this
    on Jul 8, 2022
  2. christosts commented on Jul 11, 2022

    @christosts
    Contributor

    Thank you for reporting this. We submitted a fix (this issue will be updated once the commit is pushed the dev-v2 branch) which will be included in the next release (2.18.1 or 2.19.0, which ever comes first).

  3. locked and limited conversation to collaborators on Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions