r2.16.0: How to get IcyHeaders? #9677

Activity

1. AndreasVogelfrei

   added

   needs triage

   question

   on Nov 10, 2021
2. AndreasVogelfrei

   changed the title [-]2.16.0: How to get IcyHeaders?[/-] [+]r2.16.0: How to get IcyHeaders?[/+] on Nov 10, 2021
3. christosts

   self-assigned this

   on Nov 10, 2021
4. christosts commented on Nov 11, 2021

   

   christosts

   on Nov 11, 2021

   Contributor

   More actions

   The ICY headers that you'd get in Player.Listener.onStaticMetadataChanged (name, genre, bitrate) are available in Format.metadata which you can get from Player.Listener.onTracksInfoChanged callback (note: Player.Listener.onTracksChanged is deprecated). This snippet should work

   @Override
   public void onTracksInfoChanged(TracksInfo tracksInfo) {
     for (TracksInfo.TrackGroupInfo groupInfo : tracksInfo.getTrackGroupInfos()) {
       if (groupInfo.getTrackType() == C.TRACK_TYPE_METADATA) {
         TrackGroup group = groupInfo.getTrackGroup();
         for (int i = 0; i < group.length; i++) {
           // ICY headers will be here.
           @Nullable Metadata metadata = group.getFormat(i).metadata;
         }
       }
     }
   }
   

   Let me know if this worked on your app.
5. christosts

   removed

   needs triage

   on Nov 11, 2021
6. AndreasVogelfrei commented on Nov 12, 2021

   

   AndreasVogelfrei

   on Nov 12, 2021

   Last edited by AndreasVogelfrei

   Author

   More actions

   Thanks a lot for your reply. It is working as expected with this implementation:

       @Override
       public void onTracksInfoChanged(EventTime eventTime, TracksInfo tracksInfo) {
           for (TracksInfo.TrackGroupInfo groupInfo : tracksInfo.getTrackGroupInfos()) {
               if (groupInfo.getTrackType() == C.TRACK_TYPE_METADATA) {
                   TrackGroup group = groupInfo.getTrackGroup();
                   for (int i = 0; i < group.length; i++) {
                       // ICY headers will be here.
                       @Nullable Metadata metadata = group.getFormat(i).metadata;
                       if(metadata != null) {
                           Log.v("TAG", "onTracksInfoChanged: IcyHeaders = " + metadata.toString());
                       }
                   }
               }
           }
       }
   

   Even if this is working it seems not very intuitive to find the IcyHeaders within this callback. May I suggest to implement a separate callback like "onIcyHeaderChanged" or similar?

   Anyway, thanks a lot for your support. This question is resolved and can be closed.
7. christosts

   closed this as completedon Nov 12, 2021
8. christosts commented on Nov 15, 2021

   

   christosts

   on Nov 15, 2021

   Last edited by christosts

   Contributor

   More actions

   Re-opening to improve how Icy headers are propagated to the app
9. christosts

   reopened this on Nov 15, 2021
10. christosts

    added

    enhancement

    and removed

    question

    on Nov 15, 2021
11. tonihei

    added a commit that references this issue on Nov 18, 2021

    Populate ICY headers into MediaMetadata

    ...

    349160a
12. tonihei commented on Nov 18, 2021

    

    tonihei

    on Nov 18, 2021

    Collaborator

    More actions

    Fixed by the commit above. The ICY headers will appear in onMetadataChanged as MediaMetadata.station and MediaMetadata.genre.
13. tonihei

    closed this as completedon Nov 18, 2021
14. tonihei

    added a commit that references this issue on Nov 18, 2021

    Populate ICY headers into MediaMetadata

    ...

    16e31a8
15. icbaker

    added a commit that references this issue on Nov 19, 2021

    Populate ICY headers into MediaMetadata

    ...

    d5b6250
16. google

    locked and limited conversation to collaborators on Jan 18, 2022