Add Feitian USB Dongle#257
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Thank you for your contribution! The case looks great. Your CLA bot issue might be related to the commit author, that does not match your account on GitHub? |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Can you check the author name and email with i.e. |
|
I can also offer to resend your PR if this bot is troubling you for unknown reasons. |
|
@googlebot I consent. |
* Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com>
* Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) * Fix broken parsing. (#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com>
|
@geofli so the Feitian is this using the |
|
No, they simply routed the button and the LEDs to the same pins which allows to use the same board definition. |
* Add Feitian OpenSK USB Dongle (#257) (#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (#304) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (#309) * Merge bugfix into stable (#324) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) * Fix broken parsing. (#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (#342) * Coveralls (#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (#352) * Fix coveralls workflow (#356) * Return error instead of debug assert (#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (#366) We don't use it anymore. Not sure when we used to use it. Fixes #364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
* Add Feitian OpenSK USB Dongle (google#257) (google#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (google#304) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (google#309) * Merge bugfix into stable (google#324) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) * Fix broken parsing. (google#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (google#342) * Coveralls (google#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (google#352) * Fix coveralls workflow (google#356) * Return error instead of debug assert (google#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (google#366) We don't use it anymore. Not sure when we used to use it. Fixes google#364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
* Add Feitian OpenSK USB Dongle (#257) (#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (#304) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (#309) * Merge bugfix into stable (#324) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) * Fix broken parsing. (#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (#342) * Coveralls (#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (#352) * Fix coveralls workflow (#356) * Return error instead of debug assert (#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (#366) We don't use it anymore. Not sure when we used to use it. Fixes #364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
* Add Feitian OpenSK USB Dongle (google#257) (google#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (google#304) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (google#309) * Merge bugfix into stable (google#324) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) * Fix broken parsing. (google#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (google#342) * Coveralls (google#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (google#352) * Fix coveralls workflow (google#356) * Return error instead of debug assert (google#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (google#366) We don't use it anymore. Not sure when we used to use it. Fixes google#364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
Feitian created an hardware dongle according to nRF52840 design, please refer to https://feitiantech.github.io/OpenSK_USB/hardware/ .
There is no need to change anything to Google OpenSK source code, download the OpenSK firmware to Feitian Dongle, and it can work.