Clarify stale-while-revalidate documented behavior by jeffposnick · Pull Request #9345 · google/WebFundamentals · GitHub

This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Contributor

jeffposnick commented Apr 27, 2021

R: @petele @tropicadri

Fixes GoogleChrome/workbox#2807


          Clarify SWR semantics

f275ab5

jeffposnick requested review from petele and tropicadri

April 27, 2021 20:42

google-cla bot added the cla: yes label

WebFundBot commented Apr 27, 2021

Whoops!

There were 13 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/tools/workbox/modules/workbox-strategies.md#L322 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/tools/workbox/modules/workbox-strategies.md#L48 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L72 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L93 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L111 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L129 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L153 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L178 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L204 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L233 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L278 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L310 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/modules/workbox-strategies.md#L116 - Common typo found: 'admin' Should it be 'administrator'? See: https://developers.google.com/style/word-list#administrator

tropicadri approved these changes

View reviewed changes

tropicadri merged commit 1cfee02 into main

tropicadri deleted the swr-docs-updates branch

April 30, 2021 01:32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels