fix(#37): add proper type inference to functional tool parameters t…#40
Merged
copybara-service[bot] merged 1 commit intoDec 30, 2025
Conversation
kalenkevich
approved these changes
Dec 24, 2025
efc072d to
e5812a6
Compare
…rs to auto type inference
e5812a6 to
0afb8f3
Compare
Contributor
Author
|
@kalenkevich Thanks for the approval! The comment has been resolved and the branch is now rebased with main. can you re-approve it again |
kalenkevich
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR replaces
anytypes inFunctionToolwith proper Zod generics, enabling automatic type inference from schemas to execute functions.Changes
ZodObject<any>withZodObject<ZodRawShape>inToolInputParametersToolExecuteArgumentto properly infer types usinginfer T, U, Vanycast in constructorImpact
Testing
Added test to verify type inference works without explicit type annotations. All existing tests continue to pass.
Benefits
Fixes #37