fix: exclude optional vite/eslint peer deps from esbuild bundle in adk web#319
Open
sukhmanghotraa wants to merge 2 commits into
Open
fix: exclude optional vite/eslint peer deps from esbuild bundle in adk web#319sukhmanghotraa wants to merge 2 commits into
sukhmanghotraa wants to merge 2 commits into
Conversation
…o fix adk web on missing optional deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
Running
npx adk webfails immediately when listing agents with:When
adk webloads agent files,AgentFile.load()inagent_loader.tsuses esbuild withpackages: 'bundle'to compile the agent. This pulls in all transitive dependencies includingviteandeslint, which contain optional dynamic imports forlightningcssandjiti. Since those optional peer dependencies are not installed, esbuild fails at bundle time.Solution:
Add lightningcss, jiti, and
jiti/package.jsonto theexternallist in the esbuild call insideAgentFile.load(). This is consistent with how other optional/native dependencies likesqlite3,onnxruntime-node, etc. are already handled in the same list.Testing Plan
Unit Tests:
externalconfig change. the behavior is verified byadk websuccessfully serving/list-appsafter the change.Manual End-to-End (E2E) Tests:
npx adk webstarts successfully and/list-appsresponds without errors after the fix.Checklist