Skip to content

Add dynamic metric selection and results display to evaluation UI#170

Open
Aki-07 wants to merge 5 commits into
google:mainfrom
Aki-07:feature/eval-metrics-ui
Open

Add dynamic metric selection and results display to evaluation UI#170
Aki-07 wants to merge 5 commits into
google:mainfrom
Aki-07:feature/eval-metrics-ui

Conversation

@Aki-07

@Aki-07 Aki-07 commented Oct 18, 2025

Copy link
Copy Markdown

Fixes #162

@Aki-07

Aki-07 commented Oct 18, 2025

Copy link
Copy Markdown
Author

@boyangsvl requesting for review

@boyangsvl

Copy link
Copy Markdown
Collaborator

Yifan could you help to review?

@wyf7107

wyf7107 commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator

Sure, will take a look

@wyf7107

wyf7107 commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Hi @Aki-07 , do you mind resolving the quick conflict? I then can pull this down and test it locally, thanks!

@Aki-07

Aki-07 commented Nov 25, 2025

Copy link
Copy Markdown
Author

Hey @wyf7107, have solved the conflicts, do check out

@wyf7107

wyf7107 commented Dec 30, 2025

Copy link
Copy Markdown
Collaborator

Thanks! Willl reivew great work!

@lmurawski-equinix

Copy link
Copy Markdown

Thanks! Willl reivew great work!

hi @wyf7107, can you review and merge please.

@majsterkovic

Copy link
Copy Markdown

Hi @Aki-07,

Thank you for this PR! It’s a very much-needed feature. However, I encountered several compilation errors when trying to run it locally. It seems like there are some duplicate imports and missing definitions, likely due to a merge conflict or incomplete cleanup.

Here is the list of issues preventing the build:

  1. Duplicate Identifiers in eval-tab.component.ts:
    The following components are imported twice (e.g., around lines 19-26 and again in lines 42-45), which causes TS2300 errors:
  • NgClass
  • MatIcon
  • MatProgressSpinner
  • MatTooltip
  1. Missing ChangeDetectionStrategy:
    In eval-tab.component.ts, ChangeDetectionStrategy.OnPush is used in the @component decorator, but ChangeDetectionStrategy is not included in the imports from @angular/core.

  2. Service Method Missing / Type Mismatch:
    The compiler reports that listMetricsInfo does not exist on EvalService. Please ensure that src/app/core/services/eval.service.ts is fully updated and consistent with the calls made in the component.

  3. Strict Type Errors in run-eval-config-dialog.component.ts:
    Methods getMin(metric), getMax(metric), and getStep(metric) are causing assignment errors (NG2) because they can return undefined. Adding a nullish coalescing operator (e.g., ?? 0) would resolve these strict type checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configurable metric selection and multi-metric display in Evaluation UI

5 participants