fix: decode UTF-8 text artifacts correctly in getTextContent()#453
Open
Ishihara-exture wants to merge 1 commit into
Open
fix: decode UTF-8 text artifacts correctly in getTextContent()#453Ishihara-exture wants to merge 1 commit into
Ishihara-exture wants to merge 1 commit into
Conversation
atob() returns a Latin-1 byte string, which garbles non-ASCII characters (e.g. Japanese) when renderArtifact() encodes text via btoa(unescape(encodeURIComponent(text))). Replace atob(base64) with decodeURIComponent(escape(atob(base64))) to correctly reconstruct the original Unicode string. Fixes: google#452
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wyf7107
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTextContent()inartifact-tab.component.tsusedatob(base64)which returns a Latin-1 byte string, causing non-ASCII characters (Japanese, Chinese, Korean, etc.) to appear garbled in the Artifacts tab preview and inline chat bubble.renderArtifact()encodes text viabtoa(unescape(encodeURIComponent(text)))(standard UTF-8 → base64 pattern), but the decode side was missing the reverse step.atob(base64)withdecodeURIComponent(escape(atob(base64))).Test plan
"こんにちは") viaPart.from_text()Fixes #452