Deprecate load_config.proto fields #1407
Conversation
|
|
||
| message Connectivity { | ||
| optional Vsock vsock = 1; | ||
| optional Vsock vsock = 1 [deprecated = true]; |
There was a problem hiding this comment.
vsock is in the "proposed for updated config" list in go/cf-config-flags-list .
There was a problem hiding this comment.
Thanks for the catch, that was a mistake! Removed the deprecated option.
| repeated Display displays = 1; | ||
| optional bool record_screen = 2; | ||
| optional string gpu_mode = 3; | ||
| optional string gpu_mode = 3 [deprecated = true]; |
There was a problem hiding this comment.
go/cf-config-flags-list mentions this should still be present, but limited to "auto" or "off" rather than the full set of options supported by our internal tools.
There was a problem hiding this comment.
Yes. I thought we would change this to a new enum type. From what I read in the proto best practices about type changes I believe that change might be an issue. My plan was to deprecate this and introduce a new, limited field once we get to the point of removal.
I can leave a comment with that information, unless you disagree with the above plan.
EDIT: Found a reference, string to enum is listed as an unsafe change.
|
|
||
| message Streaming { | ||
| optional string device_id = 1; | ||
| optional string device_id = 1 [deprecated = true]; |
There was a problem hiding this comment.
This one is meant to be use by the orchestrators. Don't deprecate.
There was a problem hiding this comment.
Removed the deprecated option.
75ad284 to
89d514b
Compare
Bug: 432329063
To spare us the build noise until they are removed.
89d514b to
5a0a785
Compare
|
Looks like this triggers |
|
According to go/deprecation-policy it's valid to mark something as deprecated if there is a replacement available at the time of deprecation. |
And suppress the build warnings from those deprecations.
Bug: 432329063