Skip to content

base: cvd: MODULE.bazel: upgrade clang version to 19.1.0 #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

base: cvd: MODULE.bazel: upgrade clang version to 19.1.0 #1599

wants to merge 4 commits into from
+8 −4

Conversation

@grandpaul
Copy link
Collaborator

@grandpaul grandpaul commented Sep 1, 2025

Debian Trixie (13) is already released as a new stable release. Currently andorid-cuttlefish doesn't build on Trixie because the clang it uses depends on libtinfo5. Upgrading to 19.1.0 solves the issue and thus we can remove the dependencies of libtinfo5.

This commit is tested to be built on both Debian Trixie and Bookworm.

@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Sep 2, 2025
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Sep 2, 2025
@cjreynol
Copy link
Collaborator

cjreynol commented Sep 2, 2025

Related to #1327 where there was a similar change to bump the llvm_version

@grandpaul
Copy link
Collaborator Author

grandpaul commented Sep 4, 2025

Related to #1327 where there was a similar change to bump the llvm_version

In #1327 it mentioned that we probable need an upgrade. But I tested with pbuilder in Bookworm and Trixie. Both builds.
The test is failed. Not sure why. Can I access the error log?

@Databean
Copy link
Member

Databean commented Sep 4, 2025

@grandpaul I sent you an invitation to join the repository members, which hopefully should give access to see the logs.

In the meantime, I see two errors. It looks like two new clang-tidy tests fail:

//cuttlefish/host/commands/tcp_connector:tcp_connector_clang_tidy        FAILED in 0.1s
  /home/runner/.cache/bazel/_bazel_runner/a1ea073c0d21ddc5ae89652639f74223/execroot/_main/bazel-out/k8-fastbuild/testlogs/cuttlefish/host/commands/tcp_connector/tcp_connector_clang_tidy/test.log
//cuttlefish/host/libs/config:cuttlefish_config_clang_tidy               FAILED in 0.1s
  /home/runner/.cache/bazel/_bazel_runner/a1ea073c0d21ddc5ae89652639f74223/execroot/_main/bazel-out/k8-fastbuild/testlogs/cuttlefish/host/libs/config/cuttlefish_config_clang_tidy/test.log

For arm64 specifically, it can't find a prebuilt to download:

INFO: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /root/.cache/bazel/_bazel_root/86add146dd382dd24750dce66e8a10be/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
ERROR: /root/.cache/bazel/_bazel_root/86add146dd382dd24750dce66e8a10be/external/toolchains_llvm+/toolchain/internal/llvm_distributions.bzl:660:13: An error occurred during the fetch of repository 'toolchains_llvm++llvm+llvm_toolchain_llvm':
   Traceback (most recent call last):
	File "/root/.cache/bazel/_bazel_root/86add146dd382dd24750dce66e8a10be/external/toolchains_llvm+/toolchain/internal/repo.bzl", line 311, column 35, in llvm_repo_impl
		updated_attrs = _download_llvm(rctx)
	File "/root/.cache/bazel/_bazel_root/86add146dd382dd24750dce66e8a10be/external/toolchains_llvm+/toolchain/internal/llvm_distributions.bzl", line 617, column 56, in download_llvm
		urls, sha256, strip_prefix = _distribution_urls(rctx)
	File "/root/.cache/bazel/_bazel_root/86add146dd382dd24750dce66e8a10be/external/toolchains_llvm+/toolchain/internal/llvm_distributions.bzl", line 660, column 13, in _distribution_urls
		fail("Unknown LLVM release: %s\nPlease ensure file name is correct." % basename)
Error in fail: Unknown LLVM release: LLVM-19.1.0-Linux-ARM64.tar.xz
Please ensure file name is correct.
ERROR: no such package '@@toolchains_llvm++llvm+llvm_toolchain_llvm//': Unknown LLVM release: LLVM-19.1.0-Linux-ARM64.tar.xz
Please ensure file name is correct.
ERROR: /root/.cache/bazel/_bazel_root/86add146dd382dd24750dce66e8a10be/external/toolchains_llvm++llvm+llvm_toolchain/BUILD.bazel:115:10: @@toolchains_llvm++llvm+llvm_toolchain//:compiler-components-aarch64-linux depends on @@toolchains_llvm++llvm+llvm_toolchain_llvm//:include in repository @@toolchains_llvm++llvm+llvm_toolchain_llvm which failed to fetch. no such package '@@toolchains_llvm++llvm+llvm_toolchain_llvm//': Unknown LLVM release: LLVM-19.1.0-Linux-ARM64.tar.xz
Please ensure file name is correct.

@grandpaul grandpaul force-pushed the paulliu-clang-910 branch 8 times, most recently from 71cc566 to 72a8b55 Compare September 10, 2025 21:19
@grandpaul grandpaul force-pushed the paulliu-clang-910 branch 5 times, most recently from ef53305 to b07de63 Compare September 24, 2025 02:57
@grandpaul grandpaul force-pushed the paulliu-clang-910 branch 3 times, most recently from 7ace117 to 069dbf0 Compare September 26, 2025 21:49
@Databean Databean added the kokoro:run Run e2e tests. label Sep 29, 2025
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Sep 29, 2025
@grandpaul
base: cvd: MODULE.bazel: upgrade toolchains_llvm to 1.4.0
b8f32b2 
Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
@grandpaul
base: cvd: MODULE.bazel: upgrade clang version to 19.1.7
19ab089 
Debian Trixie (13) is already released as a new stable release.
Currently andorid-cuttlefish doesn't build on Trixie because
the clang it uses depends on libtinfo5. Upgrading to 19.1.7
solves the issue and thus we can remove the dependencies of libtinfo5.

This commit is tested to be built on both Debian Trixie and Bookworm.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
@grandpaul
base: cvd: cuttlefish: host: porting code to clang 19.1.0
d94e1b1 
clang 19.1.0 checks the code stricter. We need to fix the errors reported
by the compiler.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
@grandpaul
.github: workflows: presubmit.yaml: tweak free-disk-space options
34eca06 
Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
@3405691582 3405691582 added the kokoro:run Run e2e tests. label Nov 4, 2025
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grandpaul @cjreynol @Databean @3405691582 @GoogleCuttlefishTesterBot