Update crosvm pin and build hacks, then package the executable #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemoreira
approved these changes
Sep 12, 2025
929e6fa to
29ec5c8
Compare
29ec5c8 to
c31e33c
Compare
This still requires `--enable_sandbox=false` when used with `--host_substitutions=all`, but it's good enough for now. Tested that it works with `--enable_sandbox=false` for `--gpu_mode=guest_swiftshader` and `--gpu_mode=gfxstream`. Bug: b/402274999
c31e33c to
c7b70ed
Compare
jmacnak
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still requires
--enable_sandbox=falsewhen used with--host_substitutions=all, but it's good enough for now.Tested that it works with
--enable_sandbox=falsefor--gpu_mode=guest_swiftshaderand--gpu_mode=gfxstream.Bug: b/402274999