Initial guest metrics gathering #1737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ed99b1 to
4baf950
Compare
Databean
approved these changes
Oct 30, 2025
Also, create a container type to hold the expanding number of fields that need to be passed.
The new constructor for the `Avb` class is necessary because the default lookup relies on `ANDROID_HOST_OUT` or `HOME` from the environment. `cvd` tends to set those values specifically in the context of `Command` construction to avoid unexpected behavior for users. The `Avb` class hides its `Command` construction, so it seemed better to surface the path dependency rather than try to expose the internal `Command` environment. Bug: 450049144
Bug: 450049144
Convert input parameters to `GetGuestInfo` into a format I can easily turn into a vector. Bug: 450049144
4baf950 to
fb99e5a
Compare
Despite semantically being errors, users will have no context for any of the error messages. They will still be logged in full in the `metrics/metrics.log` file. Given that metrics errors do not abort a `cvd` run, there is no reason for the console noise. Also, use the nicely formatted error output.
Previously, metrics were only gathered for the first device. Now, there should be a `CuttlefishGuest` message for each device. Bug: 450049144
For consistency with other paths.
e7a7b1c to
a013cce
Compare
Preferring the user or `cvd` identifiers rather than generating sequential numbers. Bug: 450049144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 450049144