2011: Installing contents from benchmark's tools/ subdirectory.#2016
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
let me know when you've signed the CLA and i will take a look. thank you! |
|
Hello @dmah42, I have completed the CLA. |
|
@BuildMonkey you need to deal with the CLA check. |
3d31c0c to
cecc312
Compare
|
The CLA should be good now. |
| if (NOT DEFINED CMAKE_INSTALL_PYTOOLSDIR) | ||
| set(CMAKE_INSTALL_PYTOOLSDIR "${CMAKE_INSTALL_DATADIR}/googlebenchmark/tools" CACHE PATH "") | ||
| endif() |
There was a problem hiding this comment.
Thinking about it more, i don't believe those guards should be there,
let's just always set()...
|
Err, could you rebase this? All those commits should not be there. |
This Pull Request (PR) relates to the following issue:
#2011 (comment)
I modeled my change against how benchmark docs are installed, except tools do not have a comparable CMAKE_INSTALL_DOCDIR variable recognised by build systems. Instead, I used CMAKE_INSTALL_PREFIX.
Additional, like docs, I have tools subdirectory installed by default, but we can change if this isn't the optimal behaviour.
Fixes #2011.