Improve our handling of floats and float constants. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL makes two changes: * Rename generated C++ constants from SCREAMING_SNAKE_CASE to kUpperCamelCase. * Map rust infinity and nan to their std::numeric_limits counterparts. Previously, we mapped Rust infinity to `Inff` and NAN to `Nanf` which are not valid C++ values. The C++ constant rename gets around a name collision with existing C++ macros `INFINITY` and `NAN`. Because these are macros we can't avoid the collision, so we work around it with the rename. PiperOrigin-RevId: 827657369
3095a03 to
8ed4b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve our handling of floats and float constants.
This CL makes two changes:
Previously, we mapped Rust infinity to
Inffand NAN toNanfwhich are not valid C++values. The C++ constant rename gets around a name collision with
existing C++ macros
INFINITYandNAN. Because these are macros wecan't avoid the collision, so we work around it with the rename.