Skip to content

added Einsum layer#3710

Merged
1 commit merged into
google:mainfrom
chiamp:einsum
Mar 5, 2024
Merged

added Einsum layer#3710
1 commit merged into
google:mainfrom
chiamp:einsum

Conversation

@chiamp

@chiamp chiamp commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

Added Einsum layer. See API docs here.

@codecov-commenter

codecov-commenter commented Feb 23, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.00000% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.56%. Comparing base (c83ee86) to head (8e56442).
⚠️ Report is 1508 commits behind head on main.

Files with missing lines Patch % Lines
flax/linen/linear.py 35.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3710      +/-   ##
==========================================
- Coverage   59.10%   58.56%   -0.55%     
==========================================
  Files         103      103              
  Lines       12426    12419       -7     
==========================================
- Hits         7345     7273      -72     
- Misses       5081     5146      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread flax/linen/linear.py Outdated
Comment on lines 295 to 296

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use canonical variables name

Suggested change
>>> params = layer.init(jax.random.key(0), jnp.ones((3, 4, 5)))
>>> jax.tree_map(jnp.shape, params)
>>> variables = layer.init(jax.random.key(0), jnp.ones((3, 4, 5)))
>>> jax.tree_map(jnp.shape, variables)

@copybara-service copybara-service Bot closed this pull request by merging all changes into google:main in 49a8dde Mar 5, 2024
@chiamp chiamp deleted the einsum branch March 5, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants