[nnx] always fold_in on fork + new ForkedKeys return type#3722
Merged
Conversation
839dff7 to
159e542
Compare
159e542 to
52c63bc
Compare
levskaya
approved these changes
Feb 28, 2024
levskaya
approved these changes
Feb 28, 2024
52c63bc to
5eca0f1
Compare
5eca0f1 to
3e69350
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
+ Coverage 59.00% 59.05% +0.04%
==========================================
Files 103 103
Lines 12422 12438 +16
==========================================
+ Hits 7330 7345 +15
- Misses 5092 5093 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rngs.forknow returns a singleForkedKeystype instead of different types depending on theoverload(overloads are removed).ForkedKeysis aMapping[str, Array]with the keys, and contains.splitsand.broadcastsattributes of typedict[str, Array]for cases when you need to tell apart the splits from the broadcasts.Rngs.forknow folds all keys so there is no need to maintain / propagate hashable data.RngStream.counts: list[int]is replaced withRngStream.count: int.