Skip to content

[nnx] cleanup graph_utils#3728

Merged
copybara-service[bot] merged 1 commit into
mainfrom
nnx-cleanup-graph-utils
Mar 8, 2024
Merged

[nnx] cleanup graph_utils#3728
copybara-service[bot] merged 1 commit into
mainfrom
nnx-cleanup-graph-utils

Conversation

@cgarciae

@cgarciae cgarciae commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

What does this PR do?

Simplifies graph_utils.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter

codecov-commenter commented Feb 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 58.76%. Comparing base (7d6de00) to head (f3b57e1).

Files Patch % Lines
flax/experimental/nnx/nnx/graph_utils.py 72.34% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3728      +/-   ##
==========================================
- Coverage   58.85%   58.76%   -0.10%     
==========================================
  Files         103      103              
  Lines       12318    12307      -11     
==========================================
- Hits         7250     7232      -18     
- Misses       5068     5075       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae cgarciae force-pushed the nnx-cleanup-graph-utils branch 4 times, most recently from aa606b0 to 4b2ddad Compare March 1, 2024 23:35
@cgarciae cgarciae force-pushed the nnx-cleanup-graph-utils branch from 4b2ddad to f3b57e1 Compare March 1, 2024 23:39
@copybara-service copybara-service Bot merged commit 0c7d256 into main Mar 8, 2024
@copybara-service copybara-service Bot deleted the nnx-cleanup-graph-utils branch March 8, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants