[nnx] preserve the function's type information in jit#4981
Merged
Conversation
jburnim
reviewed
Sep 25, 2025
| ) -> JitWrapped: ... | ||
| ) -> JitWrapped[P, R]: ... | ||
| def jit( | ||
| fun: tp.Callable[..., tp.Any] | type[Missing] = Missing, |
Member
There was a problem hiding this comment.
Does the signature for fun have to be updated here, as well?
Collaborator
Author
There was a problem hiding this comment.
yes, nice catch! updated.
52d106b to
566daf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses
typing.ParamSpecto properly annotateJitWrapped.__call__, this effectively preserves the original function's call type information so the inputs and outputs will be correctly checked by the type checkers.