Update optimizer.py to support masked variable from optax.#4904
Merged
Conversation
Contributor
Author
|
Tests don't pass, so this simple fix can't be right. Withdrawn. |
Collaborator
|
@ywrt not sure why they don't pass but I think you have the right idea |
Collaborator
|
oh its just mypy, I think you just have to rebase |
Collaborator
|
seems like |
Collaborator
|
@ywrt can you please rebase your PR to move it forward. Thanks ! |
Contributor
Author
|
Ok, I think this is rebased now? |
Collaborator
|
@ywrt can you please execute the following on your machine to make this PR up to date with git checkout patch-1
# assuming "origin" is pointing to git@github.com:google/flax.git
git pull origin main -r
# assuming "fork" is pointing to your fork: git@github.com:ywrt/flax.git
git push fork patch-1 -fThanks! |
vfdev-5
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #4901 the current code doesn't work with masked variable introduced by optax.partition() because it assumes that the value is an array.
This change just uses x.value to get the value directly, instead of using x[...] to get in implicitly.
What does this PR do?
Fixes #4901
Checklist
checks if that's the case).