Add tree-mode support to nnx.scan#5262
Merged
Merged
Conversation
470c118 to
b5ad29e
Compare
Adds `TreeScanFn` dataclass and `graph` parameter to `nnx.scan`, enabling tree-mode operation when `graph=False`. Tree-mode enforces default `in_axes=(Carry, 0)` and `out_axes=(Carry, 0)`, checks carry Variable identity preservation across iterations, and performs alias checks on scan outputs. Also parametrizes existing scan tests and adds new tree-mode specific tests. PiperOrigin-RevId: 873044806
b5ad29e to
934d53c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tree-mode support to nnx.scan
Adds
TreeScanFndataclass andgraphparameter tonnx.scan, enablingtree-mode operation when
graph=False. Tree-mode enforces defaultin_axes=(Carry, 0)andout_axes=(Carry, 0), checks carry Variableidentity preservation across iterations, and performs alias checks on scan
outputs. Also parametrizes existing scan tests and adds new tree-mode
specific tests.