This repository was archived by the owner on Jun 30, 2025. It is now read-only.
cmake_package_config_generate: Fix CMake warnings with CMake 3.23 #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
=======================================
Coverage 72.78% 72.78%
=======================================
Files 17 17
Lines 3259 3259
=======================================
Hits 2372 2372
Misses 887 887 Continue to review full report at Codecov.
|
Correct syntax to run CMake built-in command-line tools is `cmake -E`: https://cmake.org/cmake/help/v3.23/manual/cmake.1.html#run-a-command-line-tool This test was mistakenly using `cmake env ... cmake ...`, where `env` and second `cmake` were interpreted as paths (of source directory or build directory), resulting in "Ignoring extra path from command line" CMake warnings with CMake 3.23: https://gitlab.kitware.com/cmake/cmake/-/commit/eacf1f879b0933509efbd4fb4d6d72ce99412aa7
Contributor
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct syntax to run CMake built-in command-line tools is
cmake -E:https://cmake.org/cmake/help/v3.23/manual/cmake.1.html#run-a-command-line-tool
This test was mistakenly using
cmake env ... cmake ..., whereenvand secondcmakewere interpreted as paths (of source directory or build directory), resulting in "Ignoring extra path from command line" CMake warnings with CMake 3.23.Warnings in verbose test log (
${glob_build_dir}/Testing/Temporary/LastTest.log) may look in this way:This type of cmake warning was originally introduced by cmake commit eacf1f879b0933509efbd4fb4d6d72ce99412aa7.