Removing 3 service hooks endpoints from the code and the test #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
approved these changes
Feb 2, 2019
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joshuabezaleel!
LGTM.
Awaiting second LGTM before merging.
Note to self: must bump the release number after this breaking API change.
gauntface
approved these changes
Feb 2, 2019
Contributor
gauntface
left a comment
There was a problem hiding this comment.
Thank you for the clean up @joshuabezaleel
Collaborator
|
Thank you, @gauntface! |
Contributor
Author
|
This is my first PR, thank you very much @gmlewis @gauntface , for allowing to do so. It gave me great encouragement. Will definitely try to contribute more in the future! |
joshuabezaleel
pushed a commit
to joshuabezaleel/go-github
that referenced
this pull request
Feb 15, 2019
…he test file (google#1111)" (google#1115) This reverts commit cf38b2b. The version will be bumped.
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
…he test file (google#1111)" (google#1115) This reverts commit cf38b2b. The version will be bumped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1109
According to this post, there will be 3 endpoints affected which will be deprecated: Edit a Hook, Test a Hook, and Ping a Hook. This PR removes the code regarding those 3 endpoints and also from the test file.
cc: @gmlewis