Skip to content

Add common Installation field to webhook events #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2021
Merged

Add common Installation field to webhook events #2101

merged 2 commits into from
Sep 19, 2021
+246 −38

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Sep 19, 2021

Closes: #2099.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 19, 2021
@gmlewis gmlewis requested a review from wesleimp September 19, 2021 20:30
@codecov
Copy link

codecov bot commented Sep 19, 2021 •
edited
Loading

Codecov Report

Merging #2101 (1cbea81) into master (bd8dd52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2101   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         109      109           
  Lines        9724     9724           
=======================================
  Hits         9508     9508           
  Misses        150      150           
  Partials       66       66
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <ø> (ø)
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8dd52...1cbea81. Read the comment docs.

@gmlewis gmlewis mentioned this pull request Sep 19, 2021
Closed
rr-nick-tan
rr-nick-tan approved these changes Sep 19, 2021
View reviewed changes
Copy link

@rr-nick-tan rr-nick-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx @gmlewis

@gmlewis gmlewis merged commit c7b9c2e into google:master Sep 19, 2021
@gmlewis gmlewis deleted the add-installation-workflow-run-event branch September 19, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleimp wesleimp Awaiting requested review from wesleimp

1 more reviewer

@rr-nick-tan rr-nick-tan rr-nick-tan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmlewis @rr-nick-tan