feat: support specifying repository names #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2123 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 112 112
Lines 9956 9956
=======================================
Hits 9735 9735
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Oct 12, 2021
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ericnorris !
LGTM.
Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I noticed that the installation access token API seems to support specifying repository names instead of IDs. This makes restricting the scope of the token a lot easier, as you don't need to look up the repository ID first.
This PR adds the
repositoriesfield to theInstallationTokenOptionsstruct in order to support this functionality.