Improve JsonWriter#value(Number) performance
#2702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For JDK number types other than `Float` and `Double` there is no need to check if the number string is NaN or Infinity.
eamonnmcmanus
requested changes
Jun 17, 2024
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
This looks like a good improvement. One very nitpicky comment.
eamonnmcmanus
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve
JsonWriter#value(Number)performance for JDK number typesDescription
For JDK number types other than
FloatandDoublethere is no need to check if the number string is NaN or Infinity.This was an oversight when I originally added the validation in #2060.