Repository navigation
Provide OSGI Bundle #688
Description
Activity
Original comment posted by mikael.barbero on 2011-08-14 at 07:28 AM
http://code.google.com/p/guava-osgi/ provides OSGI re-packaging of the Guava JAR archives.
Original comment posted by kevinb@google.com on 2011-08-16 at 03:46 PM
Should we import that project into a trunk/osgi directory in Guava itself? Users seem repeatedly confused about this.
Labels:
Type-Task
CC: konigsberg@google.comOriginal comment posted by mikael.barbero on 2011-08-16 at 07:44 PM
That would be fine, but it could be even better if it integrates trunk ;)
OSGi bundles are just plain old jars with some extra entries in their MANIFEST.MF. It is that little invasive !
Everything else provided by guava-osgi is eclipse equinox (the OSGi runtime of eclipse) dependant and can stay in its very own project. Moreover, I've heard that Eclipse will use Guava very soon, then all eclipse dependant artifacts may even move to eclipse.org.
Original comment posted by webmas...@fernandoribeiro.eti.br on 2011-08-17 at 04:29 AM
I'd support merging the projects very much.
Original comment posted by kevinb9n on 2011-09-01 at 05:30 PM
We think this is the right thing to do.
Status:
AcceptedOriginal comment posted by kevinb@google.com on 2011-10-05 at 05:02 AM
(No comment entered for this change.)
Labels:
Milestone-Release11Original comment posted by fry@google.com on 2011-11-16 at 07:40 PM
(No comment entered for this change.)
Labels: -
Milestone-Release11Original comment posted by holger.staudacher on 2011-12-23 at 08:56 PM
Just as a side note, when introducing some OSGi Manifest headers it would be good when the exported packages get a version, too. This enables the usage of different versions of guava within the same OSGi container (sometimes needed).
I bundled Guava myself. So, I attached the Manifest. Maybe this helps as a starting point.
Cheers Holger
Original comment posted by mikael.barbero on 2012-01-01 at 12:08 PM
I cloned guava-libraries and modified POM's files to add OSGi metadata so that future releases will be native OSGi bundles.
http://code.google.com/r/mikaelbarbero-ogsi-guava/
Please note that the version in the POM can't be "latest" as it is not a valid OSGi version number.
Regards,
Original comment posted by webmas...@fernandoribeiro.eti.br on 2012-01-02 at 02:13 PM
Mikael,
We have long had a side project providing OSGi bundles (http://code.google.com/p/guava-osgi/), the point is getting the main project to provide them instead.
Original comment posted by webmas...@fernandoribeiro.eti.br on 2012-01-02 at 02:15 PM
Holger,
I definitely agree with having version numbers in the OSGi bundles, thanks for bringing that up.
Original comment posted by mikael.barbero on 2012-01-02 at 02:38 PM
Hi,
Actually, I'm one of the guy behind the guava-osgi project :p
The goal of my pull request (i.e. modify the pom file) is to make standard Guava releases native OSGi bundles.
If it is accepted, I still want to maintain guava-osgi for its Eclipse p2 repository.
Regarding the Holger request, it should be noted that guava-osgi already provides package versioning and my patch is supporting it too.
Regards,
Original comment posted by webmas...@fernandoribeiro.eti.br on 2012-01-02 at 02:51 PM
Hi,
I didn't know that, sorry, anyway this issue is for merging the two projects, as I see very little reason to keep them apart.
Original comment posted by mikael.barbero on 2012-01-02 at 02:58 PM
I think I've been unclear. I did a clone of guava code repository to try some changes and now I'm doing a kind of "pull request" (if you're not familiar with distributed SCM, I advise you to read http://help.github.com/send-pull-requests/). I don't want to keep the http://code.google.com/r/mikaelbarbero-ogsi-guava/ after the merge.
guava-osgi will only be kept for its p2 repository.
I hope it's clearer.
Original comment posted by webmas...@fernandoribeiro.eti.br on 2012-01-02 at 03:02 PM
Sorry, very familiar with GitHub but not Google Code, hope Google takes your contribution and closes this issue soon.
16 remaining items
Original comment posted by cpovirk@google.com on 2012-03-22 at 08:53 PM
The Sonatype people finally have things fixed up, so we can test things out now. I can reproduce the problem Charles was seeing before. I've also attempted to update the other Maven patch (attached -- I hope it's more or less correct), with which I get the same verification failure.
Christian seems to have a plan in mind, so I'll leave this to him.
Original comment posted by cgruber@google.com on 2012-03-30 at 03:51 PM
I'm prioritizing this as of now.
Original comment posted by kevinb@google.com on 2012-03-30 at 05:59 PM
(No comment entered for this change.)
Labels:
Milestone-Release12Original comment posted by cpovirk@google.com on 2012-04-16 at 12:04 PM
This will be in 12.0-rc2: 2169c86
Status:
FixedOriginal comment posted by cpovirk@google.com on 2012-04-16 at 12:10 PM
(There remains more to do to better support OSGi, but I think our 12.0-rc2 changes cover the specific request of this bug...?)
Original comment posted by mikael.barbero on 2012-04-16 at 12:14 PM
everything seems ok to me. Waiting for 12.0-rc2 to test generated metadata...
Original comment posted by robert.munteanu on 2012-05-01 at 01:59 PM
I've deployed the 12.0 Guava bundle in a Sling application ( using Apache Felix ) and using the collections part of Guava works just fine.
Thanks for your efforts!
Original issue created by webmas...@fernandoribeiro.eti.br on 2011-08-14 at 12:31 AM
The project should provide a OSGI bundle in addition to the current JAR archive.