Fix calling remove after entry.setValue on an iterator for HashBiMap.inverse().
#8128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iMap.inverse()`. Also, add tests that apply not just to `HashBiMap` but to `Map` implementations in general. Gemini noticed this bug during the review for cl/778043974. It observed that our code for the inverse-direction `BiMap` was missing this call that we have in the code for the "main" direction `BiMap`. The bug appears to have existed since cl/35322418 in 2012. RELNOTES=n/a PiperOrigin-RevId: 845025562
336d771 to
db97519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix calling
removeafterentry.setValueon an iterator forHashBiMap.inverse().Also, add tests that apply not just to
HashBiMapbut toMapimplementations in general.Gemini noticed this bug during the review for cl/778043974. It observed that our code for the inverse-direction
BiMapwas missing this call that we have in the code for the "main" directionBiMap.The bug appears to have existed since cl/35322418 in 2012.
RELNOTES=n/a