Skip to content

remove old TODOs we won't do #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
copybara-service merged 2 commits into from
Sep 17, 2025
Merged

remove old TODOs we won't do #2230

copybara-service merged 2 commits into from
Sep 17, 2025

Conversation

@j2kun
Copy link
Collaborator

@j2kun j2kun commented Sep 17, 2025 •
edited
Loading

Fixes #246
Fixes #257

@j2kun j2kun changed the title remove TODO for #246 remove old TODOs we won't do Sep 17, 2025
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Sep 17, 2025
@copybara-service copybara-service bot merged commit fd3c67e into google:main Sep 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asraa asraa asraa approved these changes

Assignees

No one assigned

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize how much to unroll a loop body vs how much yosys can optimize it Generalize generate_lookup_table to support integer-valued inputs

2 participants

@j2kun @asraa