Update oss-licenses-android to v0.7.0 #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update oss-licenses-android from 0.5.0 to 0.7.0 - Replace JitPack dependencies with Maven Central artifacts - Simplify manifest configuration for license activity
yschimke
reviewed
Feb 17, 2025
| <action android:name="com.google.wear.ACTION_SHOW_LICENSE" /> | ||
| <category android:name="android.intent.category.DEFAULT" /> | ||
| </intent-filter> | ||
| tools:node="merge"> |
Collaborator
There was a problem hiding this comment.
Should we just drop this instead?
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. The explicit tools:node="merge" specification was unnecessary.
Contributor
Author
|
Thank you for the review! I'll push the fixes soon. |
- Remove redundant tools:node="merge" from `WearableOssLicensesActivity` declaration - Use self-closing tag for `WearableOssLicensesActivity`
yschimke
reviewed
Feb 17, 2025
| <category android:name="android.intent.category.DEFAULT" /> | ||
| </intent-filter> | ||
| </activity> | ||
| android:name="com.github.droibit.oss_licenses.ui.wear.compose.material.WearableOssLicensesActivity" |
Collaborator
There was a problem hiding this comment.
Sorry, I meant the whole activity. Isn't there a default one from the library?
Contributor
Author
There was a problem hiding this comment.
Ah, my mistake! Yes, The WearableOssLicensesActivity declaration can be removed.
I'll push another fix right away!
Use the default `WearableOssLicensesActivity` provided by oss-licenses-android library instead of declaring it explicitly in AndroidManifest.xml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Updated the dependency oss-licenses-android to the latest version v0.7.0.
This update includes switching the library distribution from JitPack to Maven Central, which resolves the following issue:
WHY
Due to the above changes, the groupId in the artifacts has been changed, so I manually updated the dependencies to reflect this change.
HOW
Checklist 📋