Skip to content

Rename SecondaryChip to StandardChip #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luizgrp merged 1 commit into from
Jul 9, 2022
Merged

Rename SecondaryChip to StandardChip #355

luizgrp merged 1 commit into from
Jul 9, 2022

Conversation

@luizgrp
Copy link
Member

@luizgrp luizgrp commented Jul 8, 2022 •
edited
Loading

WHAT

Rename SecondaryChip to StandardChip.

Screen Shot 2022-07-08 at 16 59 40

Screen Shot 2022-07-08 at 17 10 16

WHY

In order to allow it to also be used for primary chip.

HOW

  • Rename SecondaryChip to StandardChip;
  • Add StandardChipType enum;
  • Add chipType: StandardChipType param to StandardChip;
  • Add preview and snapshot tests for primary chip type;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp force-pushed the mediaui_standardchip branch from e07a01b to 678b477 Compare July 8, 2022 16:11
@luizgrp luizgrp force-pushed the mediaui_standardchip branch from 678b477 to 5bc906e Compare July 8, 2022 16:18
@luizgrp luizgrp requested a review from yschimke July 8, 2022 16:45
yschimke
yschimke approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming a mostly mechanical change

@luizgrp luizgrp merged commit 9bb2fd3 into google:main Jul 9, 2022
@luizgrp luizgrp deleted the mediaui_standardchip branch July 9, 2022 12:53
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luizgrp @yschimke