Skip to content

Conversation

@luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 25, 2022

WHAT

Implement cancel downloads and remove playlist.

Cancel Remove
Screenshot_20220825_133646 Screenshot_20220825_133630

WHY

In order to align with specs in Figma.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

}

@Composable
private fun EntityDialog(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could potentially be extracted to the base package in order to be used across other screens

Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, feeling like a real app.

@luizgrp luizgrp merged commit 158e0ef into google:main Aug 25, 2022
@luizgrp luizgrp deleted the media_sample_cancel_downloads branch August 25, 2022 13:17
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants