Limit the number of particles the tip modeler will emit per modeled input #413
+80
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3d8ecd to
152c3f2
Compare
…nput It turns out that one could easily make the tip modeler lock up and/or run out of memory by specifying a particle gap far smaller than than the gap between modeled inputs, forcing the tip modeler to create unbounded numbers of particle tip states. This has been fixed for now by imposing an arbitrary limit on the number of tip states between subsequent inputs. The intention is that well-designed brushes in realistic scenarios should never get anywhere near this limit. PiperOrigin-RevId: 830508565
152c3f2 to
601d99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number of particles the tip modeler will emit per modeled input
It turns out that one could easily make the tip modeler lock up and/or run out of memory by specifying a particle gap far smaller than than the gap between modeled inputs, forcing the tip modeler to create unbounded numbers of particle tip states. This has been fixed for now by imposing an arbitrary limit on the number of tip states between subsequent inputs. The intention is that well-designed brushes in realistic scenarios should never get anywhere near this limit.